Fix/better support for custom gitlab ports #1369
Conversation
yup, will be nice to keep them as a seperate PR. for easier review Nice work ! and even nicer, you can test that indeed these changes works for your self hosted gitlab use-case.. saves us from several back and forth Is it very late on your side ? Would you like to try adding some tests? if not i can add them, i have some free time |
OK, I'll re-push with just the first commit included.
Thanks! It was fun learning a new language.
Yes, it is kind of late here. I'm Eastern Time US. If you have the time, I'd appreciate it and then I can test it out tomorrow. Also, since I'm new to TypeScript, I'm not really sure of the idiomatic way to write tests. I saw that you had written a test on the original branch ( |
Co-authored-by: ANGkeith <angkeith@hotmail.sg>
ahh because those were testing for the depedency proxy variables related stuff and my |
rgalonso
force-pushed
the
fix/better-support-for-custom-gitlab-ports
branch
from
4e9bd1e to
9b2524a
Compare
ANGkeith
merged commit cbb218a
into
firecow:fix/better-support-for-custom-gitlab-ports
Ah, right. With all the back and forth, I forgot that the test was just for that feature. |
|
I see some of the regression tests failed. Sorry about that. Is there a way to test that locally? (Again, new to TypeScript.) |
|
no worries, most of it are rather trivial..
https://github.com/firecow/gitlab-ci-local?tab=readme-ov-file#scripts have you seen ^? Does it work for you ? |
|
I'd forgotten that was in the README. I was looking for a separate CONTRIBUTING.md or the like. That's working for me now. Thanks. |
Co-authored-by: ANGkeith <angkeith@hotmail.sg>
* fix: better support for custom gitlab ports * fix: support for non-standard host schema and ports (#1369) Co-authored-by: ANGkeith <angkeith@hotmail.sg> * test: fix regression test Only print port if it's defined. Update expected string to match grammar correction in production source file. * style: fix indentation * docs: update wordings * refactor: refactor * test: refactor and add test cases for predefined-variables * fix: variables set via --variable cli option should have the highest precedence * refactor: dry and change image to busybox (smaller size) * Update README.md Co-authored-by: Robert Alonso <17463757+rgalonso@users.noreply.github.com> * Update src/parser-includes.ts --------- Co-authored-by: Robert Alonso <17463757+rgalonso@users.noreply.github.com>
2 participants
This includes changes to properly support a self-hosted instance with non-standard host ports (and schema).
This PR also includes changes to support the Dependency Proxy. If you'd rather keep that separated as a separate PR, let me know. I've kept the commits separate to easily isolate these items.